Commit 0bf1f8a7 authored by Andrew Newdigate's avatar Andrew Newdigate

Do not treat `FailedPrecondition` errors as gitaly application errors

parent b4bb093b
......@@ -53,15 +53,16 @@ groups:
# Acceptable -> 1 seconds
- record: gitlab_component_apdex:ratio
labels:
type: gitaly
component: 'goserver'
expr: >
(
sum(rate(grpc_server_handling_seconds_bucket{grpc_type="unary", le="0.5", grpc_method!~"GarbageCollect|Fsck|RepackFull|RepackIncremental|CommitLanguages|CreateRepositoryFromURL|UserRebase|UserSquash|CreateFork|UserUpdateBranch|FindRemoteRepository|UserCherryPick|FetchRemote|UserRevert"}[1m])) by (environment, type, tier)
sum(rate(grpc_server_handling_seconds_bucket{type="gitaly", grpc_type="unary", le="0.5", grpc_method!~"GarbageCollect|Fsck|RepackFull|RepackIncremental|CommitLanguages|CreateRepositoryFromURL|UserRebase|UserSquash|CreateFork|UserUpdateBranch|FindRemoteRepository|UserCherryPick|FetchRemote|UserRevert"}[1m])) by (environment, type, tier)
+
sum(rate(grpc_server_handling_seconds_bucket{grpc_type="unary", le="1", grpc_method!~"GarbageCollect|Fsck|RepackFull|RepackIncremental|CommitLanguages|CreateRepositoryFromURL|UserRebase|UserSquash|CreateFork|UserUpdateBranch|FindRemoteRepository|UserCherryPick|FetchRemote|UserRevert"}[1m])) by (environment, type, tier)
sum(rate(grpc_server_handling_seconds_bucket{type="gitaly", grpc_type="unary", le="1", grpc_method!~"GarbageCollect|Fsck|RepackFull|RepackIncremental|CommitLanguages|CreateRepositoryFromURL|UserRebase|UserSquash|CreateFork|UserUpdateBranch|FindRemoteRepository|UserCherryPick|FetchRemote|UserRevert"}[1m])) by (environment, type, tier)
)
/
2 / (sum(rate(grpc_server_handling_seconds_count{grpc_type="unary", grpc_method!~"GarbageCollect|Fsck|RepackFull|RepackIncremental|CommitLanguages|CreateRepositoryFromURL|UserRebase|UserSquash|CreateFork|UserUpdateBranch|FindRemoteRepository|UserCherryPick|FetchRemote|UserRevert"}[1m])) by (environment, type, tier) > 0)
2 / (sum(rate(grpc_server_handling_seconds_count{type="gitaly", grpc_type="unary", grpc_method!~"GarbageCollect|Fsck|RepackFull|RepackIncremental|CommitLanguages|CreateRepositoryFromURL|UserRebase|UserSquash|CreateFork|UserUpdateBranch|FindRemoteRepository|UserCherryPick|FetchRemote|UserRevert"}[1m])) by (environment, type, tier) > 0)
- name: GitLab Service Apdex Scores
interval: 1m
......
......@@ -11,6 +11,7 @@ groups:
# api/web/sidekiq/git:unicorn
- record: gitlab_component_errors:rate
labels:
# type from series: ` api/web/sidekiq/git`
component: 'unicorn'
expr: >
sum by (environment, tier, type) (rate(http_request_duration_seconds_count{job="gitlab-unicorn", status=~"^5.*"}[1m]))
......@@ -18,6 +19,7 @@ groups:
# sidekiq
- record: gitlab_component_errors:rate
labels:
type: sidekiq
component: 'sidekiq'
expr: >
sum by (environment, tier, type) (rate(sidekiq_jobs_failed_total{type = "sidekiq"}[1m]))
......@@ -25,9 +27,10 @@ groups:
# gitaly:goserver
- record: gitlab_component_errors:rate
labels:
type: gitaly
component: 'goserver'
expr: >
sum by (environment, tier, type) (rate(grpc_server_handled_total{type="gitaly", grpc_code!~"^(OK|NotFound|Unauthenticated|AlreadyExists)$"}[1m]))
sum by (environment, tier, type) (rate(grpc_server_handled_total{type="gitaly", grpc_code!~"^(OK|NotFound|Unauthenticated|AlreadyExists|FailedPrecondition)$"}[1m]))
- name: GitLab Service Errors-per-Second Rates
interval: 1m
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment