Merge branch 'jarv/show-errors' into 'master'

No longer suppress errors

See merge request gitlab-com/migration!199

bin/scripts/02_failover/060_go/p04/check-gcp-recovery.sh

@@ -12,6 +12,6 @@ fi
 
 for secondary in ${POSTGRESQL_GCP_SECONDARIES[*]}
 do
-    recovery=$(ssh_host "$secondary" "sudo gitlab-psql  -t -d gitlab_repmgr -c 'select pg_is_in_recovery();' 2>/dev/null")
+    recovery=$(ssh_host "$secondary" "sudo gitlab-psql  -t -d gitlab_repmgr -c 'select pg_is_in_recovery();'")
     echo "$secondary : pg_is_in_recovery=$recovery"
 done

bin/scripts/02_failover/060_go/p04/shutdown-azure-primary.sh

@@ -10,7 +10,7 @@ if [[ -z $POSTGRESQL_AZURE_PRIMARY ]]; then
   echo "You must set POSTGRESQL_AZURE_PRIMARY in source_vars"
 fi
 
-recovery=$(ssh_host "$POSTGRESQL_AZURE_PRIMARY" "sudo gitlab-psql  -t -d gitlab_repmgr -c 'select pg_is_in_recovery();' 2>/dev/null")
+recovery=$(ssh_host "$POSTGRESQL_AZURE_PRIMARY" "sudo gitlab-psql  -t -d gitlab_repmgr -c 'select pg_is_in_recovery();'")
 echo "$POSTGRESQL_AZURE_PRIMARY: pg_is_in_recovery=$recovery"
 
 echo "postgresql will be shutdown on the above host, press enter to continue"

bin/scripts/02_failover/060_go/p04/shutdown-azure-secondaries.sh

@@ -12,7 +12,7 @@ fi
 
 for secondary in ${POSTGRESQL_AZURE_SECONDARIES[*]}
 do
-    recovery=$(ssh_host "$secondary" "sudo gitlab-psql  -t -d gitlab_repmgr -c 'select pg_is_in_recovery();' 2>/dev/null")
+    recovery=$(ssh_host "$secondary" "sudo gitlab-psql  -t -d gitlab_repmgr -c 'select pg_is_in_recovery();'")
     echo "$secondary : pg_is_in_recovery=$recovery"
 done
 

bin/scripts/02_failover/060_go/p04/update-priority.sh

@@ -9,4 +9,4 @@ source "${UNSYMLINKED_SCRIPT_DIR}/../../../../workflow-script-commons.sh"
 if [[ -z $POSTGRESQL_AZURE_PRIMARY ]]; then
   echo "You must set POSTGRESQL_AZURE_PRIMARY in source_vars"
 fi
-ssh_host "$POSTGRESQL_AZURE_PRIMARY"  "sudo gitlab-psql -t -d gitlab_repmgr -c \"update repmgr_gitlab_cluster.repl_nodes set priority=100 where name like '%g${FAILOVER_ENVIRONMENT}%'\" 2>/dev/null"
+ssh_host "$POSTGRESQL_AZURE_PRIMARY"  "sudo gitlab-psql -t -d gitlab_repmgr -c \"update repmgr_gitlab_cluster.repl_nodes set priority=100 where name like '%g${FAILOVER_ENVIRONMENT}%'\""

bin/workflow-script-commons.sh

@@ -20,7 +20,7 @@ function die() {
 
 function ssh_host() {
   # shellcheck disable=SC2068
-  ssh -o StrictHostKeyChecking=no $@ 2>/dev/null
+  ssh -o StrictHostKeyChecking=no $@
 }
 
 function PRODUCTION_ONLY() {