Merge branch 'sh-reduce-memory-usage-smaps' into 'master'

Reduce memory allocations parsing smaps files

See merge request gitlab-org/gitlab-monitor!92

lib/gitlab_monitor/memstats.rb

+# frozen_string_literal: true
+
 require_relative "memstats/mapping"
 
 # Ported from https://github.com/discourse/discourse/blob/master/script/memstats.rb

lib/gitlab_monitor/memstats/mapping.rb

+# frozen_string_literal: true
+
 module GitLab
   module Monitor
     module MemStats
@@ -56,7 +58,9 @@ module GitLab
         end
 
         def parse_first_line(line)
-          parts = line.strip.split
+          line.strip!
+
+          parts = line.split
           @address_start, @address_end = parts[0].split("-")
           @perms = parts[1]
           @offset = parts[2]
@@ -66,8 +70,15 @@ module GitLab
         end
 
         def parse_field_line(line)
-          parts = line.strip.split
-          field = parts[0].downcase.sub(":", "")
+          line.strip!
+
+          parts = line.split
+
+          return unless parts
+
+          parts[0].downcase!
+          parts[0].sub!(":", "")
+          field = parts[0]
 
           return unless respond_to? "#{field}="
 

lib/gitlab_monitor/process.rb

+# frozen_string_literal: true
+
 require_relative "memstats"
 
 module GitLab