Unverified Commit b290c32b authored by Ben Kochie's avatar Ben Kochie
Browse files

Fix sidekiq metric names

* Fix consistency of `_jobs` as the "type".
* Remove extraneous `_count` and `_total` on gauges.
* Update README.
parent f4c4ef9c
Pipeline #98372 passed with stage
in 31 seconds
......@@ -33,8 +33,8 @@ metrics.
* Count -- `process_count`
* Memory usage -- `process_memory_bytes`
1. [Sidekiq](lib/gitlab_monitor/sidekiq.rb) -- `sidekiq_queue_size`,
`sidekiq_queue_latency`, `sidekiq_enqueued_jobs_count`,
`sidekiq_running_jobs_count`, `sidekiq_jobs_to_be_retried_count`
`sidekiq_queue_latency`, `sidekiq_enqueued_jobs`, `sidekiq_dead_jobs`,
`sidekiq_running_jobs`, `sidekiq_to_be_retried_jobs`
### Setup with GitLab Development Kit
......
......@@ -55,7 +55,7 @@ module GitLab
end
job_stats.each do |class_name, count|
@metrics.add("sidekiq_enqueued_jobs_count", count, name: class_name)
@metrics.add("sidekiq_enqueued_jobs", count, name: class_name)
end
self
......@@ -73,7 +73,7 @@ module GitLab
end
worker_stats.each do |class_name, count|
@metrics.add("sidekiq_running_jobs_count", count, name: class_name)
@metrics.add("sidekiq_running_jobs", count, name: class_name)
end
self
......@@ -89,7 +89,7 @@ module GitLab
end
retry_stats.each do |class_name, count|
@metrics.add("sidekiq_jobs_to_be_retried_count", count, name: class_name)
@metrics.add("sidekiq_to_be_retried_jobs", count, name: class_name)
end
self
......@@ -98,7 +98,7 @@ module GitLab
def probe_dead
return self unless connected?
@metrics.add("sidekiq_dead_jobs_total", Sidekiq::Stats.new.dead_size)
@metrics.add("sidekiq_dead_jobs", Sidekiq::Stats.new.dead_size)
self
end
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment